Change in osmo-ttcn3-hacks[master]: PCU: f_imm_ass_verify_{ul, dl}_tbf_ass(): use 'in' qualifier

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed May 6 19:29:14 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18078 )

Change subject: PCU: f_imm_ass_verify_{ul,dl}_tbf_ass(): use 'in' qualifier
......................................................................

PCU: f_imm_ass_verify_{ul,dl}_tbf_ass(): use 'in' qualifier

We don't need a copy of the whole RR Immediate Assignment message.

Change-Id: I44417460126e507a0a47a5aee8c4a995085023fa
Signed-off-by: Vadim Yanitskiy <axilirator at gmail.com>
---
M pcu/PCU_Tests.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index 48cdd54..e848ea6 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -359,7 +359,7 @@
 				  bts_nr := bts_nr);
 }
 
-private function f_imm_ass_verify_ul_tbf_ass(GsmRrMessage rr_imm_ass, out PacketUlAssign ul_tbf_ass)
+private function f_imm_ass_verify_ul_tbf_ass(in GsmRrMessage rr_imm_ass, out PacketUlAssign ul_tbf_ass)
 runs on RAW_PCU_Test_CT return boolean {
 
 	/* Make sure we received an UL TBF Assignment */
@@ -381,7 +381,7 @@
 	return true;
 }
 
-private function f_imm_ass_verify_dl_tbf_ass(GsmRrMessage rr_imm_ass, out PacketDlAssign dl_tbf_ass)
+private function f_imm_ass_verify_dl_tbf_ass(in GsmRrMessage rr_imm_ass, out PacketDlAssign dl_tbf_ass)
 runs on RAW_PCU_Test_CT return boolean {
 
 	/* Make sure we received a DL TBF Assignment */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18078
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I44417460126e507a0a47a5aee8c4a995085023fa
Gerrit-Change-Number: 18078
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200506/4b747b4f/attachment.htm>


More information about the gerrit-log mailing list