Change in osmo-ttcn3-hacks[master]: PCU: fix f_establish_tbf(): always expect Uplink TBF

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed May 6 19:29:14 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18077 )

Change subject: PCU: fix f_establish_tbf(): always expect Uplink TBF
......................................................................

PCU: fix f_establish_tbf(): always expect Uplink TBF

In response to a CHANNEL REQUEST received on BCCH, the network
would never allocate a Downlink TBF, so we should always expect
an Uplink TBF assignment.

Change-Id: I6b4c108bed39ba9ac9b6144827bc1e20b04333b4
Signed-off-by: Vadim Yanitskiy <axilirator at gmail.com>
---
M pcu/PCU_Tests.ttcn
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved
  laforge: Looks good to me, approved



diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index 4acde04..48cdd54 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -328,6 +328,7 @@
 /* One phase packet access (see 3GPP TS 44.018, table 9.1.8.1) */
 private const BIT8 chan_req_def := '01111000'B;
 
+/* Establish an Uplink TBF by sending RACH.ind towards the PCU */
 private function f_establish_tbf(out GsmRrMessage rr_imm_ass, uint8_t bts_nr := 0,
 				 uint16_t ra := bit2int(chan_req_def),
 				 uint8_t is_11bit := 0,
@@ -354,7 +355,7 @@
 
 	/* Expect Immediate (TBF) Assignment on TS0/AGCH */
 	return f_pcuif_rx_imm_ass(rr_imm_ass, PCU_IF_SAPI_AGCH,
-				  tr_IMM_TBF_ASS(?, ra, fn),
+				  tr_IMM_TBF_ASS(false, ra, fn),
 				  bts_nr := bts_nr);
 }
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18077
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6b4c108bed39ba9ac9b6144827bc1e20b04333b4
Gerrit-Change-Number: 18077
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200506/8b8384a7/attachment.htm>


More information about the gerrit-log mailing list