Change in osmo-ttcn3-hacks[master]: PCU: fix TC_ta_rach_imm_ass(): properly match Timing Advance

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed May 6 15:28:17 UTC 2020


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18080 )


Change subject: PCU: fix TC_ta_rach_imm_ass(): properly match Timing Advance
......................................................................

PCU: fix TC_ta_rach_imm_ass(): properly match Timing Advance

This test case would not fail even in case of Timing Advance mismatch.

Change-Id: Ife86e5e0e39f0112b854ed9a13e9c6f3c49531c9
Signed-off-by: Vadim Yanitskiy <axilirator at gmail.com>
---
M pcu/PCU_Tests.ttcn
1 file changed, 3 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/80/18080/1

diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index 865c0ee..4e6b6b8 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -728,8 +728,9 @@
 		}
 
 		/* Make sure Timing Advance IE matches out expectations */
-		if (match(rr_msg, tr_IMM_TBF_ASS(dl := false, ta := ta))) {
-			setverdict(pass);
+		if (rr_msg.payload.imm_ass.timing_advance != ta) {
+			setverdict(fail, "Timing Advance mismatch");
+			mtc.stop;
 		}
 	}
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18080
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ife86e5e0e39f0112b854ed9a13e9c6f3c49531c9
Gerrit-Change-Number: 18080
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200506/26519788/attachment.htm>


More information about the gerrit-log mailing list