This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18079 ) Change subject: PCU: cosmetic: simplify f_imm_ass_verify_ul_tbf_ass() ...................................................................... PCU: cosmetic: simplify f_imm_ass_verify_ul_tbf_ass() Do not match the whole RR Immediate Assignment, only the Rest Octets. Change-Id: If0affebb5944a657d4382fbc6d2c2bdeae444425 Signed-off-by: Vadim Yanitskiy <axilirator at gmail.com> --- M pcu/PCU_Tests.ttcn 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/79/18079/1 diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index e848ea6..865c0ee 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -361,10 +361,11 @@ private function f_imm_ass_verify_ul_tbf_ass(in GsmRrMessage rr_imm_ass, out PacketUlAssign ul_tbf_ass) runs on RAW_PCU_Test_CT return boolean { + var IaRestOctets rest_octets := rr_imm_ass.payload.imm_ass.rest_octets; /* Make sure we received an UL TBF Assignment */ - if (match(rr_imm_ass, tr_IMM_TBF_ASS(dl := false, rest := tr_IaRestOctets_ULAss(?)))) { - ul_tbf_ass := rr_imm_ass.payload.imm_ass.rest_octets.hh.pa.uldl.ass.ul; + if (match(rest_octets, tr_IaRestOctets_ULAss(?))) { + ul_tbf_ass := rest_octets.hh.pa.uldl.ass.ul; log("Rx Uplink TBF assignment: ", ul_tbf_ass); setverdict(pass); } else { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18079 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If0affebb5944a657d4382fbc6d2c2bdeae444425 Gerrit-Change-Number: 18079 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200506/d962b330/attachment.htm>