Change in osmo-ttcn3-hacks[master]: PCU: fix f_establish_tbf(): use proper CHANNEL REQUEST by default

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed May 6 15:28:16 UTC 2020


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18076 )


Change subject: PCU: fix f_establish_tbf(): use proper CHANNEL REQUEST by default
......................................................................

PCU: fix f_establish_tbf(): use proper CHANNEL REQUEST by default

Back in September 2019, while writing the first lines of the new
test infrastructure for OsmoPCU, I picked a random value as the
default RA (CHANNEL REQUEST message) for Uplink TBF establishment.

It has been accepted by the IUT so far, and still works, but
according to 3GPP TS 44.018, table 9.1.8.1, value '3A'O has
nothing to do with GPRS - it actually means 'Answer to paging'.

The new value belongs to range '011110xx' - one phase packet
access with request for single timeslot uplink transmission.

Change-Id: Ic036d380af3667d54a3a0a011a9d56a87e0f949b
Signed-off-by: Vadim Yanitskiy <axilirator at gmail.com>
---
M pcu/PCU_Tests.ttcn
1 file changed, 5 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/76/18076/1

diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index c69101b..4acde04 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -325,9 +325,12 @@
 	return false;
 }
 
-/* FIXME: properly encode RA (see TS 24.060, table 11.2.5.2) */
+/* One phase packet access (see 3GPP TS 44.018, table 9.1.8.1) */
+private const BIT8 chan_req_def := '01111000'B;
+
 private function f_establish_tbf(out GsmRrMessage rr_imm_ass, uint8_t bts_nr := 0,
-				 uint16_t ra := oct2int('3A'O), uint8_t is_11bit := 0,
+				 uint16_t ra := bit2int(chan_req_def),
+				 uint8_t is_11bit := 0,
 				 PCUIF_BurstType burst_type := BURST_TYPE_0,
 				 TimingAdvance ta := 0)
 runs on RAW_PCU_Test_CT return boolean {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18076
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic036d380af3667d54a3a0a011a9d56a87e0f949b
Gerrit-Change-Number: 18076
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200506/a332e8b2/attachment.htm>


More information about the gerrit-log mailing list