Change in osmo-bsc[master]: om2k: Fix TS channel config payload for non-superchannel case

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

tnt gerrit-no-reply at lists.osmocom.org
Tue May 5 20:03:55 UTC 2020


tnt has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18062 )

Change subject: om2k: Fix TS channel config payload for non-superchannel case
......................................................................

om2k: Fix TS channel config payload for non-superchannel case

* In superchannel mode, those 3 are required.
* In normal mode, "Config Type" is optional and the two others are
forbidden.

Signed-off-by: Sylvain Munaut <tnt at 246tNt.com>
Change-Id: If02d02c067ae8af8ce693ddfb8747212f3f4e441
---
M src/osmo-bsc/abis_om2000.c
1 file changed, 8 insertions(+), 4 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/abis_om2000.c b/src/osmo-bsc/abis_om2000.c
index d5eb24a..355389b 100644
--- a/src/osmo-bsc/abis_om2000.c
+++ b/src/osmo-bsc/abis_om2000.c
@@ -1479,10 +1479,14 @@
 		msgb_tv_put(msg, OM2K_DEI_LSC_FILT_TIME, 10);	/* units of 100ms */
 		msgb_tv_put(msg, OM2K_DEI_CALL_SUPV_TIME, 8);
 		msgb_tv_put(msg, OM2K_DEI_ENCR_ALG, 0x00);
-		/* Not sure what those below mean */
-		msgb_tv_put(msg, 0x9e, 0x00);
-		msgb_tv_put(msg, 0x9f, 0x37);
-		msgb_tv_put(msg, 0xa0, 0x01);
+
+		/* Those are only use for superchannel */
+		if (ts->trx->bts->rbs2000.use_superchannel) {
+			msgb_tv_put(msg, OM2K_DEI_CONFIG_TYPE,  0x00);	/* 1-bit, lsb */
+			msgb_tv_put(msg, OM2K_DEI_JITTER_SIZE,  0x37);
+			msgb_tv_put(msg, OM2K_DEI_PACKING_ALGO, 0x01);
+		}
+
 		break;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18062
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If02d02c067ae8af8ce693ddfb8747212f3f4e441
Gerrit-Change-Number: 18062
Gerrit-PatchSet: 1
Gerrit-Owner: tnt <tnt at 246tNt.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200505/dcf73f5e/attachment.htm>


More information about the gerrit-log mailing list