This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/18021 )
Change subject: mobile: traffic req check: support EFR
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/c/osmocom-bb/+/18021/2/src/host/layer23/src/common/l1ctl.c
File src/host/layer23/src/common/l1ctl.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/18021/2/src/host/layer23/src/common/l1ctl.c@898
PS2, Line 898: * FIXME: this is FR only, check for TCH/F (FR) and TCH/H (HR) */
: /* RFC 3551, section 4.5.8 GSM */
: if (frame_len != 13) {
actually, the code claims to be FR only, but then it actually checks for 13 and not 33. Also,we do have #defines for the frame lengths in libosmocore. I mentioned this to you before.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/18021
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Iba84f5d60ff5b1a2db8fb6af5131e185965df7c9
Gerrit-Change-Number: 18021
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 05 May 2020 06:38:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200505/5b887efa/attachment.htm>