Change in osmo-bts[master]: scheduler_trx: fix RSSI calculation for SUB frames

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon May 4 19:32:56 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18035 )

Change subject: scheduler_trx: fix RSSI calculation for SUB frames
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

Would be also nice to have a more universal solution for all kinds of measurements (+ToA256, +C/I), not only RSSI.

https://gerrit.osmocom.org/c/osmo-bts/+/18035/1/src/osmo-bts-trx/scheduler_trx.c 
File src/osmo-bts-trx/scheduler_trx.c:

https://gerrit.osmocom.org/c/osmo-bts/+/18035/1/src/osmo-bts-trx/scheduler_trx.c@1281 
PS1, Line 1281: RSSI_FR_LOWER_FOUR
Why only four bursts? A regular TCH/F or FACCH/F frame is interleaved over 8 bursts, so you need to calculate AVG for all of them.


https://gerrit.osmocom.org/c/osmo-bts/+/18035/1/src/osmo-bts-trx/scheduler_trx.c@1330 
PS1, Line 1330: LOGL_INFO
Unrelated change.


https://gerrit.osmocom.org/c/osmo-bts/+/18035/1/src/osmo-bts-trx/scheduler_trx.c@1559 
PS1, Line 1559: RSSI_HR_MID_TWO
Same question, why only two bursts? It should be 4 for a regular speech frame.


https://gerrit.osmocom.org/c/osmo-bts/+/18035/1/src/osmo-bts-trx/scheduler_trx.c@1617 
PS1, Line 1617: LOGL_INFO
Unrelated change.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18035
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I902bb47d68742d2589156f61099b67a0edbaf40b
Gerrit-Change-Number: 18035
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Mon, 04 May 2020 19:32:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200504/c006150d/attachment.htm>


More information about the gerrit-log mailing list