Change in osmo-ttcn3-hacks[master]: library: System Information: use RestOctets where possible

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sun May 3 18:58:12 UTC 2020


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18012 )


Change subject: library: System Information: use RestOctets where possible
......................................................................

library: System Information: use RestOctets where possible

The 'RestOctets' is a sub-type of the 'octetstring' with additional
padding attributes. Let's use it for SI2bis, SI2ter, and SI6 too.

Change-Id: I183d3ba9000e3ced8ecce74a4390b80075ddf25d
Signed-off-by: Vadim Yanitskiy <axilirator at gmail.com>
---
M library/GSM_SystemInformation.ttcn
1 file changed, 12 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/12/18012/1

diff --git a/library/GSM_SystemInformation.ttcn b/library/GSM_SystemInformation.ttcn
index a4688cd..4cabd77 100644
--- a/library/GSM_SystemInformation.ttcn
+++ b/library/GSM_SystemInformation.ttcn
@@ -135,14 +135,18 @@
 	type record SystemInformationType2bis {
 		NeighbourCellDescription	extd_bcch_freq_list,
 		RachControlParameters		rach_control,
-		OCT1				rest_octets
-	} with { variant "" };
+		RestOctets			rest_octets
+	} with {
+		variant (rest_octets) "FIELDLENGTH(1)"
+	};
 
 	/* 44.018 9.1.34 */
 	type record SystemInformationType2ter {
 		NeighbourCellDescription2	extd_bcch_freq_list,
-		OCT4				rest_octets
-	} with { variant "" };
+		RestOctets			rest_octets
+	} with {
+		variant (rest_octets) "FIELDLENGTH(4)"
+	};
 
 	/* 44.018 9.1.35 */
 	type record SystemInformationType3 {
@@ -199,8 +203,10 @@
 		LocationAreaIdentification	lai,
 		CellOptionsSacch		cell_options,
 		BIT8				ncc_permitted,
-		OCT7				rest_octets
-	} with { variant "" };
+		RestOctets			rest_octets
+	} with {
+		variant (rest_octets) "FIELDLENGTH(7)"
+	};
 
 	type union SystemInformationUnion {
 		SystemInformationType1		si1,

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18012
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I183d3ba9000e3ced8ecce74a4390b80075ddf25d
Gerrit-Change-Number: 18012
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200503/10687083/attachment.htm>


More information about the gerrit-log mailing list