Change in libosmo-netif[master]: amr: Fix OA to BWE conversion for SID frames.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

ipse gerrit-no-reply at lists.osmocom.org
Sat May 2 22:04:26 UTC 2020


Hello dexter, Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/libosmo-netif/+/17997

to look at the new patch set (#4).

Change subject: amr: Fix OA to BWE conversion for SID frames.
......................................................................

amr: Fix OA to BWE conversion for SID frames.

Size of a single AMR SID frame doesn't reduce by a byte when converted
from octet-aligned to bandwidth-efficient mode. So old code generated
truncated SID frames which are 1 byte short. This patch fixes
the length calculation by properly counting bits.

Proper bit counting is also bringing us one small step closer to
properly handlig multi-frame AMR packets.

Change-Id: I9fc5fb92e9bada22a47a82fcfb0925e892e50ced
---
M include/osmocom/netif/amr.h
M src/amr.c
M tests/amr/amr_test.c
M tests/amr/amr_test.ok
4 files changed, 145 insertions(+), 73 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/97/17997/4
-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/17997
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I9fc5fb92e9bada22a47a82fcfb0925e892e50ced
Gerrit-Change-Number: 17997
Gerrit-PatchSet: 4
Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200502/44d5716a/attachment.htm>


More information about the gerrit-log mailing list