Change in osmo-ttcn3-hacks[master]: RLCMAC_EncDEc.cc: Fix encoding of tfi and rsb fields in Egprs Ul Hdea...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri May 1 14:39:27 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17988 )

Change subject: RLCMAC_EncDEc.cc: Fix encoding of tfi and rsb fields in Egprs Ul HdeaderType3
......................................................................

RLCMAC_EncDEc.cc: Fix encoding of tfi and rsb fields in Egprs Ul HdeaderType3

Change-Id: Id0f7cb29cf3a30aafdaaed2aca7d34277e3c975d
---
M library/RLCMAC_EncDec.cc
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/library/RLCMAC_EncDec.cc b/library/RLCMAC_EncDec.cc
index 952e2e6..88138c6 100644
--- a/library/RLCMAC_EncDec.cc
+++ b/library/RLCMAC_EncDec.cc
@@ -1040,13 +1040,13 @@
 	egprs3.si = bs2uint8(si.foi__si());
 	egprs3.cv = si.countdown();
 	egprs3.tfi_hi = si.tfi() >> 0;
-	egprs3.tfi_lo = si.tfi() >> 1;
+	egprs3.tfi_lo = si.tfi() >> 2;
 	egprs3.bsn1_hi = si.bsn1() >> 0;
 	egprs3.bsn1_lo = si.bsn1() >> 5;
 	egprs3.cps_hi = si.cps() >> 0;
 	egprs3.cps_lo = si.cps() >> 2;
 	egprs3.spb = bs2uint8(si.spb());
-	egprs3.rsb = bs2uint8(si.spb());
+	egprs3.rsb = bs2uint8(si.rsb());
 	egprs3.pi = si.pfi__ind();
 	egprs3.spare = 0;
 	egprs3.dummy = 0;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17988
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id0f7cb29cf3a30aafdaaed2aca7d34277e3c975d
Gerrit-Change-Number: 17988
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200501/4de4b88a/attachment.htm>


More information about the gerrit-log mailing list