Change in libosmocore[master]: logging: use LOGL_NOTICE when not loglevel is set

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue Mar 31 08:02:28 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17604 )

Change subject: logging: use LOGL_NOTICE when not loglevel is set
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/17604/2/src/logging.c 
File src/logging.c:

https://gerrit.osmocom.org/c/libosmocore/+/17604/2/src/logging.c@1046 
PS2, Line 1046: osmo_log_info->cat
As an alternative solution (preferred), we can use a temporary pointer here, and then assign its value to osmo_log_info->cat:

  struct log_info_cat *cat = talloc_zero_array(...);
  // Do whatever we need to do ...
  osmo_log_info->cat = cat;


https://gerrit.osmocom.org/c/libosmocore/+/17604/2/src/logging.c@1064 
PS2, Line 1064: *(uint8_t*) (&
AFAIU, this is needed because struct log_info_cat *cat is marked as const. Can we just drop this qualifier?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17604
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib9e180261505062505fc4605a98023910f76cde6
Gerrit-Change-Number: 17604
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 31 Mar 2020 08:02:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200331/fc15834c/attachment.htm>


More information about the gerrit-log mailing list