This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17670 ) Change subject: tests/coding: check return value of encoding / decoding functions ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/17670/1/tests/coding/coding_test.c File tests/coding/coding_test.c: https://gerrit.osmocom.org/c/libosmocore/+/17670/1/tests/coding/coding_test.c@225 PS1, Line 225: printf("%s(): decoding failed (rc=%d)\n", __func__, rc); : return; rather than copy+pasting this all over, I would suggest to introduce a PRINT_RET macro which then includes the __func__ part and the return.. Or even a CHECK_RC_OR_RET() or whatever... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17670 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I78850a4ab2fb7cd63bb4a3789f934634b6fb2cb7 Gerrit-Change-Number: 17670 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Mon, 30 Mar 2020 14:35:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200330/ece8139a/attachment.htm>