Change in pysim[master]: Move parsing of GID2 to generic Card class

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

herlesupreeth gerrit-no-reply at lists.osmocom.org
Mon Mar 30 12:12:51 UTC 2020


herlesupreeth has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17657 )

Change subject: Move parsing of GID2 to generic Card class
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/17657/1/pySim/cards.py 
File pySim/cards.py:

https://gerrit.osmocom.org/c/pysim/+/17657/1/pySim/cards.py@155 
PS1, Line 155: 	def read_gid2(self):
> I think many of these methods are very similar. See e.g. read_spn, read_git1, read_git2, etc. below. […]
totally make sense. I will do so as you suggested



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/17657
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I3fe4b08c888a39cda7e7fce7a467f17908bdc3ad
Gerrit-Change-Number: 17657
Gerrit-PatchSet: 1
Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 30 Mar 2020 12:12:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200330/00505383/attachment.htm>


More information about the gerrit-log mailing list