Change in osmo-ttcn3-hacks[master]: BTS: fix as_l1_count_paging(): use ispresent() instead of isvalue()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Mar 30 10:09:01 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17655 )

Change subject: BTS: fix as_l1_count_paging(): use ispresent() instead of isvalue()
......................................................................

BTS: fix as_l1_count_paging(): use ispresent() instead of isvalue()

We actually need to check if a MI is present, i.e. not omit.

  ispresent(omit) => false
  isvalue(omit)   => true

Change-Id: I0e24e2aaa1f0da7ffdbc93ea4a19491e5dfb39b4
---
M bts/BTS_Tests.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 9534a8b..a2b4af7 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -2869,7 +2869,7 @@
 		if (match(rr, tr_PAGING_REQ1)) {
 			num_paging_rcv_msgs := num_paging_rcv_msgs + 1;
 			num_paging_rcv_ids := num_paging_rcv_ids + 1;
-			if (isvalue(rr.msgs.rrm.pagingReq_Type1.mobileIdentity2)) {
+			if (ispresent(rr.msgs.rrm.pagingReq_Type1.mobileIdentity2)) {
 				num_paging_rcv_ids := num_paging_rcv_ids + 1;
 			}
 		} else if (match(rr, tr_PAGING_REQ2)) {
@@ -2880,7 +2880,7 @@
 			if (not tmsi_is_dummy(rr.msgs.rrm.pagingReq_Type2.mobileIdentity2)) {
 				num_paging_rcv_ids := num_paging_rcv_ids + 1;
 			}
-			if (isvalue(rr.msgs.rrm.pagingReq_Type2.mobileIdentity3)) {
+			if (ispresent(rr.msgs.rrm.pagingReq_Type2.mobileIdentity3)) {
 				num_paging_rcv_ids := num_paging_rcv_ids + 1;
 			}
 		} else if (match(rr, tr_PAGING_REQ3)) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17655
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0e24e2aaa1f0da7ffdbc93ea4a19491e5dfb39b4
Gerrit-Change-Number: 17655
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200330/c34874ca/attachment.htm>


More information about the gerrit-log mailing list