Change in pysim[master]: Move parsing of PLMNwAcT to generic Card class

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Mar 30 10:06:13 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17661 )

Change subject: Move parsing of PLMNwAcT to generic Card class
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/17661/1/pySim/cards.py 
File pySim/cards.py:

https://gerrit.osmocom.org/c/pysim/+/17661/1/pySim/cards.py@101 
PS1, Line 101: 		if sw == '9000':
I think many of these methods are very similar. See e.g. read_spn, read_git1, read_git2, etc. below.

I think the proper way to address this is to have a generic method like card.read_binary('PLMNsel') and card.read_record('SMSP', 1) which can be used whenever no further parsing/decoding is requird.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/17661
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I14d7c2dc51fac6d5cf4a708a77ad23d252ba6094
Gerrit-Change-Number: 17661
Gerrit-PatchSet: 1
Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 30 Mar 2020 10:06:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200330/290cc7d0/attachment.htm>


More information about the gerrit-log mailing list