This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651 )
Change subject: iperf3: add modifier to adjust the duration of the iperf run
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/3/src/osmo_gsm_tester/iperf3.py
File src/osmo_gsm_tester/iperf3.py:
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/3/src/osmo_gsm_tester/iperf3.py@164
PS3, Line 164: if time_sec_str.endswith('h'):
You probably wanna make sure time_sec is a string here, to allow tests passing an integer:
if isinstance(time_sec_str, str) and time_sec_str.endswith('h'):
...
elif isinstance(time_sec_str, str) and time_sec_str.endswith('m'):
...
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Iff28816f83670751e9e91de31ec59b1b0ad8fc0d
Gerrit-Change-Number: 17651
Gerrit-PatchSet: 3
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 29 Mar 2020 17:28:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200329/3db9da47/attachment.htm>