Change in osmo-bsc[master]: Meas Tools: Avoid OSMO_ASSERT due to uninitialised logging.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Sat Mar 28 20:14:39 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17647 )

Change subject: Meas Tools: Avoid OSMO_ASSERT due to uninitialised logging.
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/17647/4/src/utils/meas_json.c 
File src/utils/meas_json.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/17647/4/src/utils/meas_json.c@187 
PS4, Line 187: 	void *ctx = talloc_named_const(NULL, 0, "meas_json");
afaik we usually have the root talloc context as a global variable. Better name it tall_ctx



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17647
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib3b3558723682defcee22e7ea2d8bf5c2cff1278
Gerrit-Change-Number: 17647
Gerrit-PatchSet: 4
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 28 Mar 2020 20:14:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200328/a75e3e20/attachment.htm>


More information about the gerrit-log mailing list