Change in pysim[master]: pySim-read.py: Use the method declared in cards.py to read ICCID

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

herlesupreeth gerrit-no-reply at lists.osmocom.org
Sat Mar 28 17:58:17 UTC 2020


herlesupreeth has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/17521 )

Change subject: pySim-read.py: Use the method declared in cards.py to read ICCID
......................................................................

pySim-read.py: Use the method declared in cards.py to read ICCID

Change-Id: I0dcda1ea617f3febe246b360b95887c04e5d2629
---
M pySim-read.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved
  laforge: Looks good to me, approved



diff --git a/pySim-read.py b/pySim-read.py
index bad2047..cdab462 100755
--- a/pySim-read.py
+++ b/pySim-read.py
@@ -99,9 +99,9 @@
 	card = card_detect("auto", scc) or Card(scc)
 
 	# EF.ICCID
-	(res, sw) = scc.read_binary(EF['ICCID'])
+	(res, sw) = card.read_iccid()
 	if sw == '9000':
-		print("ICCID: %s" % (dec_iccid(res),))
+		print("ICCID: %s" % (res,))
 	else:
 		print("ICCID: Can't read, response code = %s" % (sw,))
 

-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/17521
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I0dcda1ea617f3febe246b360b95887c04e5d2629
Gerrit-Change-Number: 17521
Gerrit-PatchSet: 4
Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200328/48480ea7/attachment.htm>


More information about the gerrit-log mailing list