This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17649 ) Change subject: Meas Tools, Avoid compiler format warnings ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/17649/1/src/utils/meas_vis.c File src/utils/meas_vis.c: https://gerrit.osmocom.org/c/osmo-bsc/+/17649/1/src/utils/meas_vis.c@207 PS1, Line 207: (int) The last format string modifier is %4u, so it's unsigned. This solution does not look right to me. What was the actual compiler warning? Given that there is no portable way to print time_t [1], can we consider converting time to string? [1] https://stackoverflow.com/questions/2792551/what-primitive-data-type-is-time-t https://gerrit.osmocom.org/c/osmo-bsc/+/17649/1/src/utils/meas_vis.c@291 PS1, Line 291: lu sizeof() returns size_t, so it should be %zu. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17649 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8d807ffc4571f2954e3d1083da673dc1235e7687 Gerrit-Change-Number: 17649 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith at rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Sat, 28 Mar 2020 10:43:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200328/fdba93c0/attachment.htm>