Change in osmo-bsc[master]: VTY: let all descriptions end in \n

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Mar 27 17:27:30 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17636 )

Change subject: VTY: let all descriptions end in \n
......................................................................

VTY: let all descriptions end in \n

Change-Id: I00a183078679db50567286a78c9e4f9afa3466c6
---
M src/osmo-bsc/abis_nm_vty.c
M src/osmo-bsc/bsc_vty.c
M src/osmo-bsc/osmo_bsc_vty.c
3 files changed, 18 insertions(+), 18 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/osmo-bsc/abis_nm_vty.c b/src/osmo-bsc/abis_nm_vty.c
index b1c6d56..fe467fa 100644
--- a/src/osmo-bsc/abis_nm_vty.c
+++ b/src/osmo-bsc/abis_nm_vty.c
@@ -165,7 +165,7 @@
 }
 
 DEFUN(oml_opstart, oml_opstart_cmd,
-	"opstart", "Send an OPSTART message to the object")
+	"opstart", "Send an OPSTART message to the object\n")
 {
 	struct oml_node_state *oms = vty->index;
 
diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index e9085b3..a41db9f 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -536,7 +536,7 @@
 
 DEFUN(show_bts, show_bts_cmd, "show bts [<0-255>]",
 	SHOW_STR "Display information about a BTS\n"
-		"BTS number")
+		"BTS number\n")
 {
 	struct gsm_network *net = gsmnet_from_vty(vty);
 	int bts_nr;
@@ -2560,7 +2560,7 @@
       "ccch load-indication-threshold <0-100>",
 	CCCH_STR
       "Percentage of CCCH load at which BTS sends RSL CCCH LOAD IND\n"
-      "CCCH Load Threshold in percent (Default: 10)")
+      "CCCH Load Threshold in percent (Default: 10)\n")
 {
 	struct gsm_bts *bts = vty->index;
 	bts->ccch_load_ind_thresh = atoi(argv[0]);
@@ -2575,7 +2575,7 @@
 	RACH_STR NM_STR
       "Set the NM Busy Threshold\n"
       "Set the NM Busy Threshold\n"
-      "NM Busy Threshold in dB")
+      "NM Busy Threshold in dB\n")
 {
 	struct gsm_bts *bts = vty->index;
 	bts->rach_b_thresh = atoi(argv[0]);
@@ -2679,7 +2679,7 @@
       "MS Options\n"
       "Maximum transmit power of the MS\n"
       "Maximum transmit power of the MS\n"
-      "Maximum transmit power of the MS in dBm")
+      "Maximum transmit power of the MS in dBm\n")
 {
 	struct gsm_bts *bts = vty->index;
 
@@ -2694,7 +2694,7 @@
       "cell reselection hysteresis <0-14>",
       CELL_STR "Cell re-selection parameters\n"
       "Cell Re-Selection Hysteresis in dB\n"
-      "Cell Re-Selection Hysteresis in dB")
+      "Cell Re-Selection Hysteresis in dB\n")
 {
 	struct gsm_bts *bts = vty->index;
 
@@ -2708,7 +2708,7 @@
       "Minimum RxLev needed for cell access\n"
       "Minimum RxLev needed for cell access\n"
       "Minimum RxLev needed for cell access\n"
-      "Minimum RxLev needed for cell access (better than -110dBm)")
+      "Minimum RxLev needed for cell access (better than -110dBm)\n")
 {
 	struct gsm_bts *bts = vty->index;
 
@@ -2749,7 +2749,7 @@
 	"temporary offset <0-60>",
 	"Cell selection temporary negative offset\n"
 	"Cell selection temporary negative offset\n"
-	"Cell selection temporary negative offset in dB")
+	"Cell selection temporary negative offset in dB\n")
 {
 	struct gsm_bts *bts = vty->index;
 
@@ -2763,7 +2763,7 @@
 	"temporary offset infinite",
 	"Cell selection temporary negative offset\n"
 	"Cell selection temporary negative offset\n"
-	"Sets cell selection temporary negative offset to infinity")
+	"Sets cell selection temporary negative offset to infinity\n")
 {
 	struct gsm_bts *bts = vty->index;
 
@@ -2793,7 +2793,7 @@
 	"Cell selection penalty time\n"
 	"Set cell selection penalty time to reserved value 31, "
 		"(indicate that CELL_RESELECT_OFFSET is subtracted from C2 "
-		"and TEMPORARY_OFFSET is ignored)")
+		"and TEMPORARY_OFFSET is ignored)\n")
 {
 	struct gsm_bts *bts = vty->index;
 
@@ -2840,7 +2840,7 @@
 	GPRS_TEXT
 	"GPRS Cell Settings\n"
 	"GPRS BSSGP VC Identifier\n"
-	"GPRS BSSGP VC Identifier")
+	"GPRS BSSGP VC Identifier\n")
 {
 	/* ETSI TS 101 343: values 0 and 1 are reserved for signalling and PTM */
 	struct gsm_bts *bts = vty->index;
@@ -2859,7 +2859,7 @@
 	"gprs nsei <0-65535>",
 	GPRS_TEXT
 	"GPRS NS Entity Identifier\n"
-	"GPRS NS Entity Identifier")
+	"GPRS NS Entity Identifier\n")
 {
 	struct gsm_bts *bts = vty->index;
 
@@ -2880,7 +2880,7 @@
 	"gprs nsvc <0-1> nsvci <0-65535>",
 	GPRS_TEXT NSVC_TEXT
 	"NS Virtual Connection Identifier\n"
-	"GPRS NS VC Identifier")
+	"GPRS NS VC Identifier\n")
 {
 	struct gsm_bts *bts = vty->index;
 	int idx = atoi(argv[0]);
@@ -3131,7 +3131,7 @@
 	"gprs 11bit_rach_support_for_egprs (0|1)",
 	GPRS_TEXT "11 bit RACH options\n"
 	"Disable 11 bit RACH for EGPRS\n"
-	"Enable 11 bit RACH for EGPRS")
+	"Enable 11 bit RACH for EGPRS\n")
 {
 	struct gsm_bts *bts = vty->index;
 
@@ -4200,8 +4200,8 @@
 DEFUN(cfg_trx,
       cfg_trx_cmd,
       "trx <0-255>",
-	TRX_TEXT
-      "Select a TRX to configure")
+      TRX_TEXT
+      "Select a TRX to configure\n")
 {
 	int trx_nr = atoi(argv[0]);
 	struct gsm_bts *bts = vty->index;
diff --git a/src/osmo-bsc/osmo_bsc_vty.c b/src/osmo-bsc/osmo_bsc_vty.c
index e656d70..c372b48 100644
--- a/src/osmo-bsc/osmo_bsc_vty.c
+++ b/src/osmo-bsc/osmo_bsc_vty.c
@@ -539,7 +539,7 @@
       cfg_msc_acc_lst_name_cmd,
       "access-list-name NAME",
       "Set the name of the access list to use.\n"
-      "The name of the to be used access list.")
+      "The name of the to be used access list.\n")
 {
 	struct bsc_msc_data *msc = bsc_msc_data(vty);
 
@@ -792,7 +792,7 @@
       cfg_bsc_acc_lst_name_cmd,
       "access-list-name NAME",
       "Set the name of the access list to use.\n"
-      "The name of the to be used access list.")
+      "The name of the to be used access list.\n")
 {
 	struct osmo_bsc_data *bsc = osmo_bsc_data(vty);
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17636
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I00a183078679db50567286a78c9e4f9afa3466c6
Gerrit-Change-Number: 17636
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200327/318dcfbc/attachment.htm>


More information about the gerrit-log mailing list