Change in osmo-pcu[master]: Move gsm_rlcmac.cpp -> .c

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Mar 27 15:21:52 UTC 2020


Hello fixeria, laforge, osmith, Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-pcu/+/17627

to look at the new patch set (#2).

Change subject: Move gsm_rlcmac.cpp -> .c
......................................................................

Move gsm_rlcmac.cpp -> .c

Original file from wireshark.git (packet-gsm_csn1.c) is being built and
maintained as a C file. There's no real need for us to maintain it as a
C++, and doing so will make both files derive over time (as already
happened). Let's keep it as a C compiler (which btw seems to be more
strict) to make it easier to port patches back and forth wireshark.git.

Take the chance to move some declarations we added to csn1.h to be able
to build it out of wireshark. Let's keep those in a separate header file
to ease looking for differences.

Change-Id: I818a8ae947f002d35142f9f5473454cfd80e1830
---
M src/Makefile.am
M src/bts.h
M src/csn1.h
M src/decoding.h
M src/encoding.h
M src/gprs_rlcmac.h
R src/gsm_rlcmac.c
M src/gsm_rlcmac.h
M src/pdch.cpp
M src/pdch.h
M src/tbf.cpp
A src/wireshark_compat.h
M tests/rlcmac/RLCMACTest.cpp
13 files changed, 62 insertions(+), 36 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/27/17627/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17627
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I818a8ae947f002d35142f9f5473454cfd80e1830
Gerrit-Change-Number: 17627
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200327/6fd5ec40/attachment.htm>


More information about the gerrit-log mailing list