Change in osmo-trx[master]: doc: switch log levels to notice

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Mar 27 09:30:11 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/17594 )

Change subject: doc: switch log levels to notice
......................................................................


Patch Set 2:

> Patch Set 1: Code-Review-1
> 
> > Patch Set 1:
> > 
> > I usually use osmo-trx with info level set and it looks good for me. I like seeing the clock indications to see that everything's smoothly. I'm not against the patch though, just sharing my opinion.
> 
> Same here, I am fine with INFO. Clock indications can be suspended by setting DTRXCLK to NOTICE. And I don't see what a regular user would benefit from this change... among with sending us even less informative bug reports.

The general "best practice" in Osmcoom so far is that all applications typically should have NOTICE  as a compile-time default for their log levels. This is not set in stone.  However, we should definitely not log lots of messages all the time, unless thy are e.g. triggered by user interaction (like a LU request) or something aobut a connection to another network element failing to come up (or that it was established).

The fact that apparently there is no other way (or none that you guys know of) to check if everything is allright with OsmoTRX means that you are working around the underlying cause: That this status is not easily available otherwise, either by some 'show' command, or by some event based message that's printed when the status becomes OK or becomes NOT-OK.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17594
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ief82b85d9ff0e0e94eaabd255ebea961396fff32
Gerrit-Change-Number: 17594
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 27 Mar 2020 09:30:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200327/dd5bb2bb/attachment.htm>


More information about the gerrit-log mailing list