This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17628 ) Change subject: rlcmac: support decode FDD_CELL_INFORMATION of "UTRAN FDD Description ...................................................................... Patch Set 1: Code-Review-1 (3 comments) CR-1 because you're printing pointer address. https://gerrit.osmocom.org/c/osmo-pcu/+/17628/1/src/csn1.c File src/csn1.c: https://gerrit.osmocom.org/c/osmo-pcu/+/17628/1/src/csn1.c@1438 PS1, Line 1438: (%p) Printing pointer address is not a good idea since we match debug output in the unit test. And in general, I don't see any use cases for that, since you can always find it in gdb ;) https://gerrit.osmocom.org/c/osmo-pcu/+/17628/1/src/gsm_rlcmac.c File src/gsm_rlcmac.c: https://gerrit.osmocom.org/c/osmo-pcu/+/17628/1/src/gsm_rlcmac.c@2647 PS1, Line 2647: for( i=0; i<16; i++, pCell_Sel_Param++ ) Since you're squashing some changes anyway, please fix this fancy formatting too. https://gerrit.osmocom.org/c/osmo-pcu/+/17628/1/src/gsm_rlcmac.c@2766 PS1, Line 2766: for( i=0; i<16; i++, pCell_Sel_Param++ ) Same here. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17628 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I08523bc1bbdffde479ef974b4c7b56cfa5639591 Gerrit-Change-Number: 17628 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Thu, 26 Mar 2020 19:03:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200326/2b20fcff/attachment.htm>