This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17571 ) Change subject: VTY: add show bts failure report ...................................................................... Patch Set 6: (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/17571/6/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/17571/6/src/osmo-bsc/bsc_vty.c@565 PS6, Line 565: "Clear the list of failure reports after showing them") AFAICT You need \n at the end of the last one (yes, the functions above are also wrong, feel ree to submit separate patch). https://gerrit.osmocom.org/c/osmo-bsc/+/17571/6/src/osmo-bsc/bsc_vty.c@613 PS6, Line 613: struct bts_oml_fail_rep *old = llist_last_entry(&bts->oml_fail_rep, struct bts_oml_fail_rep, You can simply use llist_for_each_safe() instead of llist_empty() + llist_last_entry(), but fine. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I18aa17a721cd5eb1c98926dc2367229c0a50bc78 Gerrit-Change-Number: 17571 Gerrit-PatchSet: 6 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Thu, 26 Mar 2020 15:23:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200326/e2c199b2/attachment.htm>