Change in osmocom-bb[master]: layer23/l1ctl: fix: do not pass PDCH and CBCH frames to LAPDm

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Mar 24 13:52:54 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17493 )

Change subject: layer23/l1ctl: fix: do not pass PDCH and CBCH frames to LAPDm
......................................................................

layer23/l1ctl: fix: do not pass PDCH and CBCH frames to LAPDm

GPRS (PDCH) and CBCH related frames have nothing to do with LAPDm.
The former uses LLC for the user-plane data, while CBCH involves
its own segmentation described in 3GPP TS 23.041 and TS 44.012.

There is currently no code for handling these kinds of frames, so
let's just send them to GSMTAP and release the memory (msgb).

Change-Id: I59b4acbe22217f8989f73b79b128a43e8bcdfa2f
Related: OS#4439
---
M src/host/layer23/src/common/l1ctl.c
1 file changed, 10 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/host/layer23/src/common/l1ctl.c b/src/host/layer23/src/common/l1ctl.c
index b6ee455..b7d0ecd 100644
--- a/src/host/layer23/src/common/l1ctl.c
+++ b/src/host/layer23/src/common/l1ctl.c
@@ -319,6 +319,16 @@
 			    dl->snr, ccch->data, sizeof(ccch->data));
 	}
 
+	/* Do not pass PDCH and CBCH frames to LAPDm */
+	switch (chan_type) {
+	case RSL_CHAN_OSMO_PDCH:
+	case RSL_CHAN_OSMO_CBCH4:
+	case RSL_CHAN_OSMO_CBCH8:
+		/* TODO: pass directly to l23 application */
+		msgb_free(msg);
+		return 0;
+	}
+
 	/* determine LAPDm entity based on SACCH or not */
 	if (dl->link_id & 0x40)
 		le = &ms->lapdm_channel.lapdm_acch;

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17493
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I59b4acbe22217f8989f73b79b128a43e8bcdfa2f
Gerrit-Change-Number: 17493
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200324/2d50b823/attachment.htm>


More information about the gerrit-log mailing list