This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17571 ) Change subject: VTY: add show bts failure report ...................................................................... Patch Set 3: (1 comment) > Patch Set 2: > > (1 comment) > > I find the implementation a bit "inteeresting" in that it neither > > a) uses the raw input data and stores that, only generating strings during "show" time, nor > b) reuses the existing libosmocore/strrb.c code for ring-buffers of strings. > > I would say that either we store the raw/binary report data in some custom structure, but if we convert everything into strings at the time the alarm happens, then I would expect strrb.c to be usable? Thanks for the review. Patch rewritten to store the raw msgb and parse it again when running the "show" command. https://gerrit.osmocom.org/c/osmo-bsc/+/17571/2/src/osmo-bsc/osmo_bsc_main.c File src/osmo-bsc/osmo_bsc_main.c: https://gerrit.osmocom.org/c/osmo-bsc/+/17571/2/src/osmo-bsc/osmo_bsc_main.c@220 PS2, Line 220: entry = talloc_zero(fail_rep->bts, struct bts_oml_fail_rep); > please either return NULL if talloc fails, or OSMO_ASSERT() on the result. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I18aa17a721cd5eb1c98926dc2367229c0a50bc78 Gerrit-Change-Number: 17571 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Tue, 24 Mar 2020 13:47:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200324/7849a5f5/attachment.htm>