Change in osmo-gsm-tester[master]: srs_enb: enable console trace, use RemoteProcess class and fix params

[srs_andre]

srs_andre has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17587 )


Change subject: srs_enb: enable console trace, use RemoteProcess class and fix params
......................................................................

srs_enb: enable console trace, use RemoteProcess class and fix params

In order for the console trace to work over SSH this commit
switches to use the default RemoteProcess class. Note that srsENB
now correctly handles the SIGHUP signal.

The commit also remove a few unneeded params of the eNB.

Change-Id: If5af43effa9145b6764a32557a20a2e1760f0486
---
M src/osmo_gsm_tester/srs_enb.py
1 file changed, 5 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/87/17587/1

diff --git a/src/osmo_gsm_tester/srs_enb.py b/src/osmo_gsm_tester/srs_enb.py
index ae9b12f..b354408 100644
--- a/src/osmo_gsm_tester/srs_enb.py
+++ b/src/osmo_gsm_tester/srs_enb.py
@@ -116,6 +116,10 @@
         else:
             self.start_locally()
 
+        # send t+Enter to enable console trace
+        self.dbg('Enabling console trace')
+        self.process.stdin_write('t\n')
+
     def start_remotely(self):
         self.inst = util.Dir(os.path.abspath(self.suite_run.trial.get_inst('srslte')))
         lib = self.inst.child('lib')
@@ -150,12 +154,10 @@
                 '--enb_files.sib_config=' + self.remote_config_sib_file,
                 '--enb_files.rr_config=' + self.remote_config_rr_file,
                 '--enb_files.drb_config=' + self.remote_config_drb_file,
-                '--expert.nof_phy_threads=1',
-                '--expert.rrc_inactivity_timer=1500',
                 '--log.filename=' + self.remote_log_file,
                 '--pcap.filename=' + self.remote_pcap_file)
 
-        self.process = self.rem_host.RemoteProcessFixIgnoreSIGHUP(srsENB.BINFILE, util.Dir(srsENB.REMOTE_DIR), args, remote_env=remote_env)
+        self.process = self.rem_host.RemoteProcess(srsENB.BINFILE, args, remote_env=remote_env)
         self.suite_run.remember_to_stop(self.process)
         self.process.launch()
 
@@ -176,8 +178,6 @@
                 '--enb_files.sib_config=' + os.path.abspath(self.config_sib_file),
                 '--enb_files.rr_config=' + os.path.abspath(self.config_rr_file),
                 '--enb_files.drb_config=' + os.path.abspath(self.config_drb_file),
-                '--expert.nof_phy_threads=1',
-                '--expert.rrc_inactivity_timer=1500',
                 '--log.filename=' + self.log_file,
                 '--pcap.filename=' + self.pcap_file)
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17587
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: If5af43effa9145b6764a32557a20a2e1760f0486
Gerrit-Change-Number: 17587
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200324/56ae7ef9/attachment.htm>