Change in osmo-gsm-tester[master]: ms: add optional param to specify fixed SPGW address assigned to MS

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Mar 24 09:54:36 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17582 )

Change subject: ms: add optional param to specify fixed SPGW address assigned to MS
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17582/1/src/osmo_gsm_tester/modem.py 
File src/osmo_gsm_tester/modem.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17582/1/src/osmo_gsm_tester/modem.py@471 
PS1, Line 471:     def set_spgw_addr(self, spgw_addr):
Do you plan to set it through test? are you already using it? otherwise I think we can drop this one for now. It probably makes more sense to change it through dictionaries, agree?


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17582/1/src/osmo_gsm_tester/resource.py 
File src/osmo_gsm_tester/resource.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17582/1/src/osmo_gsm_tester/resource.py@103 
PS1, Line 103:         'modem[].spgw_addr': schema.IPV4,
Can we have something more generic (3g vs 4g) which we can also later extend? For instance "apn_ipaddr". This way later one we may want to have a "apn" dictionary with properties inside.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17582
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ie6fcd7987dc7bc62a686bee3a10c67e3dd813419
Gerrit-Change-Number: 17582
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 24 Mar 2020 09:54:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200324/c900602a/attachment.htm>


More information about the gerrit-log mailing list