Change in osmo-pcu[master]: rlcmac: Fix bug receiving RA cap

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Mar 23 16:59:29 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17548 )

Change subject: rlcmac: Fix bug receiving RA cap
......................................................................


Patch Set 7: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/17548/7/tests/rlcmac/RLCMACTest.cpp 
File tests/rlcmac/RLCMACTest.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/17548/7/tests/rlcmac/RLCMACTest.cpp@461 
PS7, Line 461: Make sure there's 1 value (currently fails due to failed decoding)
please update this comment too


https://gerrit.osmocom.org/c/osmo-pcu/+/17548/7/tests/rlcmac/RLCMACTest.ok 
File tests/rlcmac/RLCMACTest.ok:

https://gerrit.osmocom.org/c/osmo-pcu/+/17548/7/tests/rlcmac/RLCMACTest.ok@146 
PS7, Line 146: decode_gsm_ra_cap() returns 0
to be consistent, I would also print this line from the new test



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17548
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I5334eaacfbc238fae8bea50c9e9667c2117f81ff
Gerrit-Change-Number: 17548
Gerrit-PatchSet: 7
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 23 Mar 2020 16:59:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200323/ad60d81a/attachment.htm>


More information about the gerrit-log mailing list