This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17573 ) Change subject: VTY: add "test-failure-event-report" ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/17573/2/src/common/vty.c File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/17573/2/src/common/vty.c@931 PS2, Line 931: DEFUN(send_failure_event_report, send_failure_event_report_cmd, "send-failure-event-report <0-255>", > probably adding the "test" keyword in the vty command would make it more clear that it's only to be used for testing. Good idea, done. > I think you can even check that this command is only run under no config node to make suer it's not added to the vty.cfg file. It is not attached to a config node in bts_vty_init(), so just like "show_bts_cmd" etc an extra check should not be necessary. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17573 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0c4eba1636d8faf5012db26643bdf1d9fb6bfa1e Gerrit-Change-Number: 17573 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 23 Mar 2020 15:09:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200323/7a06a50c/attachment.htm>