This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17536 ) Change subject: add srsue class member to pass additional cmd line args ...................................................................... Patch Set 1: Code-Review-2 (1 comment) I don't understand this commit. You are simply adding a class member but not using it anywhere? What's the intention? use it from tests? from scenarios? If it's to be used directly for tests, better add a public API for that, we don't usually touch class instance attributes from outside. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17536/1/src/osmo_gsm_tester/srs_ue.py File src/osmo_gsm_tester/srs_ue.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17536/1/src/osmo_gsm_tester/srs_ue.py@169 PS1, Line 169: self.additional_args) You need to add the same also for the start_locally() function, see line 205 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17536 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I969fb7f34a865218e39563844de273cf5587e3ee Gerrit-Change-Number: 17536 Gerrit-PatchSet: 1 Gerrit-Owner: Andre Puschmann <andre at softwareradiosystems.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 20 Mar 2020 16:04:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200320/69d48f42/attachment.htm>