This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17539 ) Change subject: scheduler: always call ul handler on nope ind ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/17539/1/src/common/scheduler.c File src/common/scheduler.c: https://gerrit.osmocom.org/c/osmo-bts/+/17539/1/src/common/scheduler.c@1381 PS1, Line 1381: func = trx_chan_desc[chan].ul_fn; : if (!func) : return 0; > so you don't need this check at all, just call it :) Moreover, NOPE.ind contains no burst, so bi->burst_len is 0 and bi->burst is not initialized. You either need to make sure that all Uplink handlers can deal with that (AFAIK, only rx_data_fn does), or do memset(bi->burst, 0x00, GSM_BURST_LEN); bi->burst_len = GSM_BURST_LEN here. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17539 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ice45d5986610d9bcef2a7e41f0a395ec779e3928 Gerrit-Change-Number: 17539 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Fri, 20 Mar 2020 12:49:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <axilirator at gmail.com> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200320/94cea192/attachment.htm>