This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17491 ) Change subject: main: exit on mutually exclusive codecs settings ...................................................................... Patch Set 3: > Patch Set 3: > > > Patch Set 3: > > > > Hmm, it seems before we exit for this error message, we also need a test that verifies that the error message is always accurate. If it has false positives, users will always use the allow-unusable-timeslots option and nothing is gained. > > Indeed there are no existing tests for the codec_pref.c code. I'll add tests as separate commit. Correction, there is already such a test: https://git.osmocom.org/osmo-bsc/tree/tests/codec_pref -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17491 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3ccfc3b0a8641400cb97a23b24d7ed92d2ad25cd Gerrit-Change-Number: 17491 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-CC: neels <nhofmeyr at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 19 Mar 2020 10:52:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200319/f3e84fec/attachment.htm>