Change in pysim[master]: pySim-read.py: Added card detection function like in pySim-prog.py

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Mar 19 08:57:09 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17520 )

Change subject: pySim-read.py: Added card detection function like in pySim-prog.py
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/c/pysim/+/17520/3/pySim-read.py 
File pySim-read.py:

https://gerrit.osmocom.org/c/pysim/+/17520/3/pySim-read.py@37 
PS3, Line 37: def card_detect(scc):
doesn't  it make sense to have the function once in some library and then use that libray from both programs?


https://gerrit.osmocom.org/c/pysim/+/17520/3/pysim-testdata/Wavemobile-SIM.ok 
File pysim-testdata/Wavemobile-SIM.ok:

https://gerrit.osmocom.org/c/pysim/+/17520/3/pysim-testdata/Wavemobile-SIM.ok@6 
PS3, Line 6: 6a82
> same here, any ideas why the response code changes?
this doesn't look good.  6a82 is - AFAIR - the code for "you have entered the wrong PIN and now have 2 tries left?



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/17520
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I71f57c6403dc933bd9d54f90df3d3fe105b4f66f
Gerrit-Change-Number: 17520
Gerrit-PatchSet: 3
Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 19 Mar 2020 08:57:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200319/e3f85fe9/attachment.htm>


More information about the gerrit-log mailing list