Change in simtrace2[master]: simtrace2_siff: getopt_long() returns int, not char

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Mar 19 08:22:58 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/17528 )

Change subject: simtrace2_siff: getopt_long() returns int, not char
......................................................................

simtrace2_siff: getopt_long() returns int, not char

This may be causing unwanted behavior while parsing the command
line arguments, as reported by some Raspi users.

Change-Id: I5b7db0795d16ab071e255c2c689e3b4872a933bb
Related: OS#4223
---
M host/src/simtrace2-sniff.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/host/src/simtrace2-sniff.c b/host/src/simtrace2-sniff.c
index dfb6e7c..47d9e77 100644
--- a/host/src/simtrace2-sniff.c
+++ b/host/src/simtrace2-sniff.c
@@ -342,7 +342,7 @@
 	while (1) {
 		int option_index = 0;
 
-		char c = getopt_long(argc, argv, "hi:kV:P:C:I:S:A:", opts, &option_index);
+		int c = getopt_long(argc, argv, "hi:kV:P:C:I:S:A:", opts, &option_index);
 		if (c == -1)
 			break;
 		switch (c) {

-- 
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/17528
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I5b7db0795d16ab071e255c2c689e3b4872a933bb
Gerrit-Change-Number: 17528
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200319/c84f4b24/attachment.htm>


More information about the gerrit-log mailing list