Change in pysim[master]: Added feature to parse USIM Service table (UST)

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

herlesupreeth gerrit-no-reply at lists.osmocom.org
Fri Mar 13 07:37:12 UTC 2020


herlesupreeth has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/16991 )

Change subject: Added feature to parse USIM Service table (UST)
......................................................................


Patch Set 11:

> Patch Set 11:
> 
> > Creating a class for Service Table sounds good. Do you think having Service Table object as member variable for each card type is a good idea? 
> 
> I'm not 100% sure.  After all, the Service Table is an attribute of the *instance* of a given card class.  Its contents can differer from one card to another of that product/class.  I'm not an expert on pySim code.  In theory, one would probably have something that separates the card specific code (and constant data related to a given card model) from the dynamic data that we are just reading from the filesystem of one specific card?
> 
> > And BTW, in pySim-read.py any reason why cla byte and sel_ctrl are not set based on card type (its done properly in pySim-prog.py)?
> 
> I don't think so.  In general, I would assume lots of things are just for historical reasons and the lack of any real architecture.  Any clean-up/refactoring is welcome.  With the tester in place we should be able to ensure we don't break functionality for one card type or the other.

I will try to re-factor the code for only pySim-read.py and address the detecting of applications on SIM card and based on that parse the service table. I may need some of your advice in terms of architecture since i have less experience in that aspect :).


-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/16991
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I6680e8c7f86326f72b98a33338e0dd5b58e55013
Gerrit-Change-Number: 16991
Gerrit-PatchSet: 11
Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 13 Mar 2020 07:37:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200313/6143c34e/attachment.htm>


More information about the gerrit-log mailing list