This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17456 ) Change subject: osmo-bsc/bsc_vty: set default gprs cell bvci to 2 ...................................................................... osmo-bsc/bsc_vty: set default gprs cell bvci to 2 Do not use 0 as default, as it is reserved for signalling. Related: OS#4408 Change-Id: I499272f16aadd89f3bdb5d749e3e4f9e07056c15 --- M src/osmo-bsc/bsc_vty.c A tests/gprs_bvci_default.vty 2 files changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/56/17456/1 diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index d1a268d..e858d58 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -3059,6 +3059,10 @@ bts->gprs.mode = mode; + /* 3GPP TS 08.18, chapter 5.4.1: 0 is reserved for signalling */ + if (!bts->gprs.cell.bvci) + bts->gprs.cell.bvci = 2; + return CMD_SUCCESS; } diff --git a/tests/gprs_bvci_default.vty b/tests/gprs_bvci_default.vty new file mode 100644 index 0000000..4bd95ce --- /dev/null +++ b/tests/gprs_bvci_default.vty @@ -0,0 +1,13 @@ +OsmoBSC> enable +OsmoBSC# configure terminal +OsmoBSC(config)# network +OsmoBSC(config-net)# bts 0 +OsmoBSC(config-net-bts)# gprs mode gprs +OsmoBSC(config-net-bts)# exit + +OsmoBSC(config-net)# show running-config +... + bts 0 +... + gprs cell bvci 2 +... -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17456 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I499272f16aadd89f3bdb5d749e3e4f9e07056c15 Gerrit-Change-Number: 17456 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200311/f50a23e4/attachment.htm>