Change in osmocom-bb[master]: virtphy: Delay response between L1SAP_PM_REQ and L1SAP_PM_CONF

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Mar 10 21:12:03 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17448 )

Change subject: virtphy: Delay response between L1SAP_PM_REQ and L1SAP_PM_CONF
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmocom-bb/+/17448/1/src/host/virt_phy/src/virt_prim_pm.c 
File src/host/virt_phy/src/virt_prim_pm.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/17448/1/src/host/virt_phy/src/virt_prim_pm.c@93 
PS1, Line 93: l1s->pm.req.band_arfcn_from, l1s->pm.req.band_arfcn_to
> We may also want to clear the band flags (two MSB bits) before printing ARFCN.
the entire virtphy code doesn't appear to be treating the flags correctly at all. I thought it doesn't make sense to now try to do this correctly, as I am not even sure if the data stored should be with those its or without it.  This needs a more thorough review of the entire codebase.



-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17448
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I443b5512c4966c232107aeb73e1fd8b83335d63d
Gerrit-Change-Number: 17448
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 10 Mar 2020 21:12:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200310/216c009b/attachment.htm>


More information about the gerrit-log mailing list