Change in libosmocore[master]: socket: Add osmo_sock_mcast_iface_set() to bind multicast to device

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Mar 10 18:10:00 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17418 )

Change subject: socket: Add osmo_sock_mcast_iface_set() to bind multicast to device
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/17418/4/src/socket.c 
File src/socket.c:

https://gerrit.osmocom.org/c/libosmocore/+/17418/4/src/socket.c@1215 
PS4, Line 1215: 	return setsockopt(fd, IPPROTO_IP, IP_MULTICAST_IF, &mr, sizeof(mr));
> You should ideally return -errno on error here, not -1 as setsockopt does.
I agree in principle.  However, all other functions in osmo_sock_mcast* that call setsockopt are returning its return value, and not -errno, so I think it is consistent.  If at all, the cleanup should then be done for all functions.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17418
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib52d22710020b56965aefcef09bde8247ace4a9c
Gerrit-Change-Number: 17418
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 10 Mar 2020 18:10:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200310/cf5c50c6/attachment.htm>


More information about the gerrit-log mailing list