This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17443 )
Change subject: osmo-bts-virtual: Add "virtual-um ttl <0-255>" VTY option
......................................................................
Patch Set 2:
(2 comments)
I don't see any comment regarding packets not showing up in wireshark anymore. If you fixed that I'd be interested to know why. Otherwise, It's worth writing that behavior somewhere.
https://gerrit.osmocom.org/c/osmo-bts/+/17443/2/src/osmo-bts-virtual/main.c
File src/osmo-bts-virtual/main.c:
https://gerrit.osmocom.org/c/osmo-bts/+/17443/2/src/osmo-bts-virtual/main.c@126
PS2, Line 126: plink->u.virt.ttl = -1;
Worth adding here a comment with the -1 meaning. It would actually make sense to have a define for that.
https://gerrit.osmocom.org/c/osmo-bts/+/17443/2/src/osmo-bts-virtual/virtual_um.c
File src/osmo-bts-virtual/virtual_um.c:
https://gerrit.osmocom.org/c/osmo-bts/+/17443/2/src/osmo-bts-virtual/virtual_um.c@83
PS2, Line 83: perror("Cannot set TTL of Virtual Um transmit socket");
we should avoid perror but fine since I see we use it in other places in this file, a patch to fix all of them should be submitted at some point.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17443
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I18a9f93b764aee4e1dc68a1c6ac4d078e52ca61d
Gerrit-Change-Number: 17443
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 10 Mar 2020 16:43:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200310/1e69c412/attachment.htm>