Change in osmocom-bb[master]: trxcon/scheduler: refactor TDMA frame number calculation

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Mar 9 10:55:03 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17351 )

Change subject: trxcon/scheduler: refactor TDMA frame number calculation
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/c/osmocom-bb/+/17351/4/src/host/trxcon/sched_trx.c 
File src/host/trxcon/sched_trx.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/17351/4/src/host/trxcon/sched_trx.c@750 
PS4, Line 750: 		if (i + 1 == n)
> Let's say n = 4 (typical for xCCH) and we're doing the last iteration here, so i = 3. […]
Ok, you end up with (C) in line 753, but then immediately after condition checked is 4 < 4 so the loop exits and "meas" is not used anymore. So what do you win?



-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17351
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I9221957297a6154edc1767a0e3753f5ee383173f
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 09 Mar 2020 10:55:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200309/cc0e8b2e/attachment.htm>


More information about the gerrit-log mailing list