Change in osmo-pcu[master]: csn1: fix: do not return 0 if no bits left in the buffer

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Mar 9 09:43:07 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17394 )

Change subject: csn1: fix: do not return 0 if no bits left in the buffer
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/17394/4/src/csn1.c 
File src/csn1.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/17394/4/src/csn1.c@a156 
PS4, Line 156:   if (remaining_bits_len <= 0)
What about changing it to (remaining_bits_len < 0) then? That's an error in any case, being next one optional or not. Does that make sense?

I'm wondering whether all types check against remaining_bits_len being zero or negative...



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17394
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ie3a15e210624599e39b1e70c8d34efc10c552f6c
Gerrit-Change-Number: 17394
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 09 Mar 2020 09:43:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200309/93ba48a1/attachment.htm>


More information about the gerrit-log mailing list