This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17383 ) Change subject: trxcon/scheduler: fix n_errors for BFI triggered by FACCH ...................................................................... trxcon/scheduler: fix n_errors for BFI triggered by FACCH These BFI (Bad Frame Indications) substitute speech frames stolen by FACCH/F or FACCH/H frames, so there can be no bit errors in something that was not even transmitted over the air interface. Change-Id: Icdb6209f75ead6581e3c18aeee0da9831aaa272a --- M src/host/trxcon/sched_lchan_tchf.c M src/host/trxcon/sched_lchan_tchh.c 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/host/trxcon/sched_lchan_tchf.c b/src/host/trxcon/sched_lchan_tchf.c index 788d153..6531e11 100644 --- a/src/host/trxcon/sched_lchan_tchf.c +++ b/src/host/trxcon/sched_lchan_tchf.c @@ -155,7 +155,9 @@ .toa256 = 0, .rssi = -110, }; - n_errors = 116 * 4; + + /* No bursts => no errors */ + n_errors = 0; } /* BFI is not applicable in signalling mode */ diff --git a/src/host/trxcon/sched_lchan_tchh.c b/src/host/trxcon/sched_lchan_tchh.c index 013dba9..e7037fe 100644 --- a/src/host/trxcon/sched_lchan_tchh.c +++ b/src/host/trxcon/sched_lchan_tchh.c @@ -349,7 +349,9 @@ .toa256 = 0, .rssi = -110, }; - n_errors = 116 * 2; + + /* No bursts => no errors */ + n_errors = 0; } /* Calculate TDMA frame number of the first burst */ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17383 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Icdb6209f75ead6581e3c18aeee0da9831aaa272a Gerrit-Change-Number: 17383 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200308/159e6e11/attachment.htm>