This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17377 ) Change subject: osmo-bts-virtual: implement GSMTAP_CHANNEL_VOICE ...................................................................... Patch Set 2: Code-Review-2 (2 comments) https://gerrit.osmocom.org/c/osmo-bts/+/17377/2/src/osmo-bts-virtual/l1_if.c File src/osmo-bts-virtual/l1_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/17377/2/src/osmo-bts-virtual/l1_if.c@157 PS2, Line 157: ; actually, the entire modification in this file/function is bogus: We are allocating a new tch message (different from treatment of all other gsmtap channel types here). And then we add a L1SAP header and do nothing with that new msg_tch. First of all, that means there's a memory leak. And secondly, this means that the code above L1SAP can never actually see any of the GSMTAP_CHANNEL_VOICE messages we may have received in uplink https://gerrit.osmocom.org/c/osmo-bts/+/17377/2/src/osmo-bts-virtual/scheduler_virtbts.c File src/osmo-bts-virtual/scheduler_virtbts.c: https://gerrit.osmocom.org/c/osmo-bts/+/17377/2/src/osmo-bts-virtual/scheduler_virtbts.c@427 PS2, Line 427: if (msg_facch) this modification breaks the entire FACCH substitution logic. There may be TCH and FACCH message present at the same time. The FACCH has higher priority and the TCH message is dropped. The old code did exactly that. The new code now sends both up, whcih is illegal. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17377 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1cd9a251ce0b87181a0822d7940bbfc9f1428543 Gerrit-Change-Number: 17377 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Sat, 07 Mar 2020 16:30:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200307/474560ae/attachment.htm>