This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17392 ) Change subject: rlcmac: fix encode_gsm_*(): do not suppress encoding errors ...................................................................... Patch Set 4: Code-Review-1 (2 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/17392/4/src/gsm_rlcmac.cpp File src/gsm_rlcmac.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/17392/4/src/gsm_rlcmac.cpp@5331 PS4, Line 5331: /* Returns 0 on success, negative on error. */ This description doesn't match reality after your change. https://gerrit.osmocom.org/c/osmo-pcu/+/17392/4/tests/rlcmac/RLCMACTest.cpp File tests/rlcmac/RLCMACTest.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/17392/4/tests/rlcmac/RLCMACTest.cpp@287 PS4, Line 287: log_parse_category_mask(osmo_stderr_target, "DPCU,3:DLGLOBAL,1:DRLCMACDATA,2:DCSN1,2:"); Please do this in a separate commit. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17392 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ieec8e6e0823c6f6985f9d343af6d503b8fe9e6ab Gerrit-Change-Number: 17392 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 06 Mar 2020 22:57:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200306/b2b66650/attachment.htm>