Change in pysim[master]: Added feature to parse USIM Service table (UST)

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Mar 5 15:48:18 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/16991 )

Change subject: Added feature to parse USIM Service table (UST)
......................................................................


Patch Set 11:

(1 comment)

please also note there' salso an IST (ISIM Service Table) in the ADF_ISIM.  Even if you don't have the time / energy to fully imlpement all of it, it would probably make sense to think a bit how to abstract the handling of SST+UST in a way that the same parser / code can be used for IST or even other future service tables structured in the same way.  There could e.g. be  a base class which then the SST/UST/IST specific classed derive from - probably mostly adding a list of string names for the services and a list of integers indicating those services to be printed?

https://gerrit.osmocom.org/c/pysim/+/16991/11/pySim-read.py 
File pySim-read.py:

https://gerrit.osmocom.org/c/pysim/+/16991/11/pySim-read.py@209 
PS11, Line 209: 	try:
I think this should be factored out in a separate function which knows all the AIDs (not just USIM and ISIM but at least also HPSIM?) and which simply returns the sim_type dict.

As there may be other [unknown] applications on the card, a different data format fo the return value might be best, where the [possibly unknown] application name is not the key? Just thiking aloud here.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/16991
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I6680e8c7f86326f72b98a33338e0dd5b58e55013
Gerrit-Change-Number: 16991
Gerrit-PatchSet: 11
Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 05 Mar 2020 15:48:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200305/dc64456b/attachment.htm>


More information about the gerrit-log mailing list