Change in libosmocore.git[master]: gb: Logging improvements.

[ipse]

ipse has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore.git/+/17331 )


Change subject: gb: Logging improvements.
......................................................................

gb: Logging improvements.

1. Print signalling and data weights on NS-VC creation.

2. Print an INFO message when we receive a NS-ALIVE from an unknown
IP:port. Before that it was ignored silently which was making
configuration debugging difficult for standard-compliant Gb over IP.
Now you can easily see that an SGSN is trying to connect to us.

Change-Id: Ic145bcc54e3f0779ea9e284216831b17ab22eb91
---
M src/gb/gprs_ns.c
1 file changed, 10 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore.git refs/changes/31/17331/1

diff --git a/src/gb/gprs_ns.c b/src/gb/gprs_ns.c
index 2701d72..26c80c4 100644
--- a/src/gb/gprs_ns.c
+++ b/src/gb/gprs_ns.c
@@ -318,7 +318,8 @@
 		return NULL;
 	}
 
-	LOGP(DNS, LOGL_INFO, "NSVCI=%u Creating NS-VC\n", nsvci);
+	LOGP(DNS, LOGL_INFO, "NSVCI=%u Creating NS-VC Signal weight %d, Data weight %d\n",
+	     nsvci, sig_weight, data_weight);
 
 	nsvc = talloc_zero(nsi, struct gprs_nsvc);
 	if (!nsvc)
@@ -1632,6 +1633,14 @@
 		return GPRS_NS_CS_SKIPPED;
 	}
 
+	if (nsh->pdu_type == NS_PDUT_ALIVE) {
+		/* Ignore this, see 3GPP TS 08.16, 7.4.1 */
+		LOGP(DNS, LOGL_INFO, "Ignoring NS ALIVE from %s "
+		     "for non-existing NS-VC\n",
+		     gprs_ns_ll_str(fallback_nsvc));
+		return GPRS_NS_CS_SKIPPED;
+	}
+
 	if (nsh->pdu_type == NS_PDUT_ALIVE_ACK) {
 		/* Ignore this, see 3GPP TS 08.16, 7.4.1 */
 		LOGP(DNS, LOGL_INFO, "Ignoring NS ALIVE ACK from %s "

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore.git/+/17331
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore.git
Gerrit-Branch: master
Gerrit-Change-Id: Ic145bcc54e3f0779ea9e284216831b17ab22eb91
Gerrit-Change-Number: 17331
Gerrit-PatchSet: 1
Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200303/e9594ca0/attachment.htm>