Change in osmo-ttcn3-hacks[master]: msc: verify conn and VLR cell id in most tests

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Jun 29 15:27:41 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18998 )

Change subject: msc: verify conn and VLR cell id in most tests
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18998/1/msc/BSC_ConnectionHandler.ttcn 
File msc/BSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18998/1/msc/BSC_ConnectionHandler.ttcn@62 
PS1, Line 62: import from TCCConversion_Functions { function f_strstr };
oh I thought last discussion we had about this concluded this partial including was not supported in titan, but looks like it is?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18998/1/msc/BSC_ConnectionHandler.ttcn@370 
PS1, Line 370: 	f_verify_vty_lac_ci(verify_vlr := false);
In general I'm for testing stuff in general for all tests, but I'm not really sure we want to run stuff through the VTY every time someone establishes a dedicated channel, since this really impacts time and how tests execute 8as in timing of events).

Since the function runs in BSC_ConnHdlr, what about setting a boolean there to call this verify function?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18998/1/msc/MSC_Tests.ttcn 
File msc/MSC_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18998/1/msc/MSC_Tests.ttcn@411 
PS1, Line 411: 		verify_cell_id := mp_enable_cell_id_test and verify_cell_id
So you are actualyl doing what I requested, but you are not checking the var in all places where the verify function is called. Please do so and create an extra test enabling it (or enable it in an existing test for which it makes sense).



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18998
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie410714a96353f74a52a104c56fa0a08683e0004
Gerrit-Change-Number: 18998
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 29 Jun 2020 15:27:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200629/205c39da/attachment.htm>


More information about the gerrit-log mailing list