Change in osmo-e1d[master]: VTY interface support

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19036 )

Change subject: VTY interface support
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.osmocom.org/c/osmo-e1d/+/19036/1/src/osmo-e1d.c 
File src/osmo-e1d.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/19036/1/src/osmo-e1d.c@54 
PS1, Line 54: static const char *config_file = "osmo-e1d.cfg";
> g_ prefix for consistency.
done


https://gerrit.osmocom.org/c/osmo-e1d/+/19036/1/src/osmo-e1d.c@86 
PS1, Line 86: 	"License AGPLv3+: GNU AGPL version 3 or later <http://gnu.org/licenses/agpl-3.0.html>\r\n"
> Huh this is not AGPL.
sorry, no bad intention here, was just mentally copy+pasting.


https://gerrit.osmocom.org/c/osmo-e1d/+/19036/1/src/osmo-e1d.c@189 
PS1, Line 189: 		exit(1);
> Using 'return' for one error and 'exit' for the other is weird. […]
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/19036
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I47b6e4efaad52e68e2b50a7993076f3706f86628
Gerrit-Change-Number: 19036
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Assignee: tnt <tnt at 246tNt.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 29 Jun 2020 15:24:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: tnt <tnt at 246tNt.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200629/53901495/attachment.htm>